ObliviOS Developer portal Project site

Home / Decisions / ADR-121

Show the AirPods listening-mode text inside the buttons on the native Settings device page through an opt-in extra.

Accepted, recorded 1 October 2026.

Decision
ADR-121
Date
2026-10-01
Status
AcceptedAccepted (compiled, not run on a device)
Part
AirPods
Mentions
ADR-116
Mentioned by
ADR-123

1Decision

Show the AirPods listening-mode text inside the buttons on the native Settings device page through an opt-in extra (DeviceSettingContract.TOGGLE_LABEL_IN_BUTTON) on ToggleInfo, with two small Settings patches (frameworks/base SettingsLib and packages/apps/Settings).

2Why and evidence

The approved design (ADR-116) shows the labels inside the buttons; the stock SegmentedButtonPreference shows an icon and puts the label in a separate row (SegmentedButtonPreference.kt:166-177). The owner chose exactness over a stock-look or a one-row alternative on 2026-10-01. The extra rides the existing ToggleInfo parcel, so there is no AIDL change and an older Settings simply ignores it.

3Consequences

Adds a divergence from upstream in two repositories (about 70 changed lines) that must be rebased with every GrapheneOS release; rebuilds Settings.apk, SystemUI.apk and SettingsLib users; no new permission, endpoint or IPC. Compiled on 2026-10-01 (SettingsLib, Settings, SystemUI and SettingsLibRoboTests built, 3018 steps, 0 FAILED:; the built Settings.apk contains setLabelInsideButton and TOGGLE_LABEL_IN_BUTTON). Not proven: the robolectric test run (this tree has no runner target; the test class compiled and references the new constant), that "Noise cancel" fits in a button at the default font size, and the look of the selected state against the mock.

4Review when

A rebase that changes SegmentedButtonPreference, ToggleModel, ToggleInfo.toModel or the multi-toggle branch of BluetoothDetailsConfigurableFragment; AIR-033 showing a wrapped or clipped label.

Read from docs/governance/decision-log.md, entry ADR-121.