- Decision
- ADR-255
- Date
- 2026-11-18
- Status
- AcceptedAccepted (owner, 2026-11-18: \"mag je doen\" to the assessment).
- Mentions
- ADR-253, ADR-254
1Decision
Assess the 19 OSV advisories that ADR-254 found in the npm packages of site/ (Astro 5.18.2 with 13, sharp with 3, esbuild, zod and picomatch with one each). Result: none applies to the static output or to the build of oblivios.org, and the Astro pin of ADR-253 stays.
The basis is what site/ uses: no define:vars, transition: directive, client: directive, spread props, named slot, dynamic tag name, astro:assets or MDX; no adapter, no base, no server; passthroughImageService(), so sharp is never loaded; set:html only on strings written in the repository; every input of the build is a file of the repository or the snapshot.
The table is in docs/architecture/site-engineering-notes.md, each row is an entry of advisories in tools/sbom/inputs.json, and the SBOM shows each advisory with its assessment as the detail, as it does for the Rust advisories.
2Why and evidence
The 13 advisories of Astro are fixed only in Astro 6 and 7, which need Node 22; moving the pin needs a download of Node and a new run (ADR-253), and no advisory applies, so the pin is the smaller risk. Rejected: moving to Astro 7 now, removing sharp from the lockfile (it is optional and unused), leaving the advisories unassessed.
3Consequences
Done and read on 2026-11-18: the search of every .astro, .mjs, .js and .css file of site/ and of astro.config.mjs; build-sbom.py and its --check run on the regenerated snapshot with all 20 npm vulnerability entries carrying an assessment, both documents schema-valid, 1,551 of 1,551 hashes. It is a reading of the use of each feature, not an audit of the code of Astro, and the owner has not read the table. Each regeneration of the evidence (fetch-npm-evidence.py) can list new advisories, which stay unassessed until read.
4Review when
A page or component uses a listed feature, an adapter, a base or an image service is added, Astro or Node is upgraded, a new advisory appears, or the owner rejects a row.
Read from docs/governance/decision-log.md, entry ADR-255.