ObliviOS Developer portal Project site

Home / Decisions / ADR-236

Amend ADR-195 (level 0 "every impact locks"), with ADR-204 in mind.

Accepted, recorded 16 November 2026.

Decision
ADR-236
Date
2026-11-16
Status
AcceptedAccepted 2026-11-16 (owner's choice for review B7: accept, amend the text; no code change)
Mentions
ADR-195, ADR-204

1Decision

Amend ADR-195 (level 0 "every impact locks"), with ADR-204 in mind: the minimum pulse of 120 ms (minPulseMs, patch frameworks-base/0011 of physical/grab-detection) applies at every level, the strictest included. At level 0 an impact after any free fall locks at once, as before; an impact with no free fall at all locks only after the pulse of 120 ms, so level 0 no longer locks every impact. The text of ADR-195 for level 0 is read with this limit.

2Why and evidence

Review B7 of 2026-11-unreviewed-code-review.md. [verified-in-source] physical/grab-detection/patches/frameworks-base/0002: at GRAB_IMPACT_LEVEL_STRICT the long free fall is 0 ms and the pulse rule is if (fall == 0 && mParams.minPulseMs > 0), with no level in that condition. ADR-204 gave the reason: the 4 ms spike of a pickup locked in 2 of 5 phases at level 1 and the owner did not want a lock at a pickup (2026-10-29); the 12 recorded grabs are 171 to 310 ms above 15 m/s^2. Rejected: a level-specific minimum for level 0, which touches a tuned detector and needs new measurements on a device.

3Consequences

A grab shorter than 120 ms with no free fall does not lock at any level; none is recorded (ADR-204). The pulse threshold rests on eight recorded pickups (review B17); shadow-mode records of a few days would settle it.

4Review when

Reopen if a grab shorter than 120 ms is recorded, or the owner wants level 0 to lock on every impact again.

Read from docs/governance/decision-log.md, entry ADR-236.