ObliviOS Developer portal Project site

Home / Decisions / ADR-198

Amend ADR-196 and ADR-197 after the independent review of the changes after lynx image 2026102302.

Accepted, recorded 28 October 2026.

Decision
ADR-198
Date
2026-10-28
Status
AcceptedAccepted (owner instruction 2026-10-28: yes to the user check, do what is best for the row, ask for the PIN or fingerprint; landed on the build server as vendor/freeholdos/exit 4760de5 (exitd built from freeholdos-services 2b7d137, twice with one hash) and packages/apps/Settings 290bc735639; host tests and mutations pass; built into lynx image 2026102303 (IMG-017), not on a device)
Part
Grab detection
Mentions
ADR-196, ADR-197
Mentioned by
ADR-260

1Decision

Amend ADR-196 and ADR-197 after the independent review of the changes after lynx image 2026102302 (2026-10-post-2302-review.md). (1) exitd and exitd_route accept a control peer of the type exit_app only when its uid belongs to user 0 (below 100000) as well; a run with a uid (the tests, root on a phone) still compares the uid exactly and never reads the context.

(2) In shadow mode, the default, the Lock when grabbed row selects none of its four entries, so a tap on Off writes the mode; a level outside 0 to 2 is shown as the nearest level, as GrabDetectionService clamps it; changing the row asks for the screen lock (PIN or fingerprint) as Auto reboot does. This supersedes the parts of ADR-197 (1) that say the shadow mode reads as Off and the consequence that a level outside 0 to 2 reads as Standard.

2Why and evidence

[verified-in-source] (review B1): after system-sepolicy/0004 the MLS constraints pass for an exit_app in any user, the daemon compared only the SELinux type (context_has_type, levels and categories are not compared) and a new connection of an accepted peer replaces the old one, so a copy of the exit app in the decoy or a work profile would have been accepted; the exit app itself runs only in user 0 (ExitRuntime.runsHere), which is app code and not a barrier.

Android gives each user a block of 100000 uids. [verified-in-source] (review C1): RadioButtonPickerFragment2.setDefaultKey returns without writing when the chosen key equals the current one, so Off could not be chosen while the row showed Off for the shadow mode; the picker shows no selection and no summary for a current value that is not an entry.

[verified-in-source] (review C2, C3): the service clamps the level to 0 to 2 when it arms, and AutoRebootPrefController asks for the credential.

3Consequences

The daemon and the route helper share one check, so both refuse a peer of another user; the check is a pure function of the two readings and a test stands in for the peer (check_peer_with), ten mutations are killed. The grab row shows no value in the shadow mode until the owner picks one, and every change of it asks for the lock when a lock is set. Nothing else of ADR-196 changes. NET-012 and GRB-022 carry the device checks.

4Review when

A second exit app of the right type in user 0 is not excluded (platform-signed apps only); a later multi-user exit service would have to reopen this; the Settings change is not compiled until the module build.

Read from docs/governance/decision-log.md, entry ADR-198.