- Decision
- ADR-190
- Date
- 2026-10-22
- Status
- AcceptedAccepted
- Part
- Passwords
- Mentions
- ADR-185, ADR-202
- Mentioned by
- ADR-192, ADR-193, ADR-202
1Decision
Three decisions on the Passwords app within ADR-185. (1) A login submitted on a form is offered for saving whether the vault is open or locked.
Locked, it waits in the memory of the app process for two minutes at most, the autofill framework starts an unlock step as the continuation of the save, the usual prompt runs, and the login is saved after it; nothing is written before the vault is open, a process that dies in between loses the login, and the offer appears on every login form so it tells nothing about which sites have an account (amended by ADR-202: no offer for a login the vault holds, none for a system app).
(2) Import from other managers is part of version 1: the plain CSV export of the other manager is read by one header-driven reader in the core (Bitwarden, 1Password, Chrome, Edge, Brave, Firefox, KeePass, KeePassXC, LastPass, Proton Pass, Dashlane, NordPass, Apple Passwords), through the existing import row; only logins are read, an entry the vault already has is left out, nothing is overwritten, the app asks once and tells the user to delete the file, the limits are 16 MiB and 100 000 rows.
(3) A logo row of the bundled pack is derived only when the icon is named after the registrable domain; every other row is in a hand-reviewed override list.
2Why and evidence
The owner decided (1) and (2) on 2026-10-22 (saving must always work; import in version 1, whatever is handiest). Prior art: ADR-185 and the design had no save flow while locked and left the import open; the framework starts the intent sender of a save request in the client's context (frameworks/base Session.onSaveRequestSuccess, read on the build server 2026-10-22). For (3), the first build of the pack took every row from the icons' source URLs and showed the wrong brand for several of the top 1000 domains (twitter.com showed LibraryThing, cloudfront.net Envoy); 30 icons name github.com and 127 name wikimedia.org as their source.
3Consequences
PendingSaveSlot, LoginSaver and SaveAuthActivity in freeholdos-platform/passwords/app (row PWM-012); vault-core/src/csvimport.rs and the importCsv call in freeholdos-services (row PWM-013); the pack in passwords/logos/. The prebuilt libvault_core.so has to be rebuilt before the next module build. The CSV file the user exports stays on the phone's storage until the user deletes it, which the app cannot guarantee on flash storage.
4Review when
A device test shows that the unlock step does not start from some browsers or apps, or that the process dies between the offer and the unlock often enough to lose logins; the owner wants encrypted exports only; an export of a manager the owner uses is not recognised; a wrong brand logo is found on a domain of the override list.
Read from docs/governance/decision-log.md, entry ADR-190.