ObliviOS Developer portal Project site

Home / Decisions / ADR-143

The AirPods code (the app, the codec and the Bluetooth patches) got its first independent code review.

Proposed, recorded 7 October 2026.

Decision
ADR-143
Date
2026-10-07
Status
ProposedProposed
Part
AirPods
Mentions
ADR-144
Mentioned by
ADR-144

1Decision

The AirPods code (the app, the codec and the Bluetooth patches) got its first independent code review; its fixes land without a new design.

App: the Settings listener broadcast is serialised, every state listener runs when one fails, the metadata writer and the ear detection value are reset at unbond, a first pairing starts its session from the audio connection (the bond completes before the UUIDs are known), the bond change reaches the app through a receiver the running process registers (the system never delivers it to a manifest receiver in the background), a session that got no settings is restarted once after the audio connected, the exported receiver ignores foreign actions, the backoff is reset only after a session that lasted 30 s, a failing createL2capSocket is retried, a failing Play sound leaves no playing state, a slider shows a value on its grid.

Codec: AapCodec.isValidName refuses a name that starts or ends in a space separator and the code points that draw nothing. Patch 0013 of packages/modules/Bluetooth applies the same rule to AirPodsAliasPolicy. Play sound keeps the measured gains of AIR-190 (start 0.25, factor 1.6 every 2 s, cap 1.0); the threat review row T24 is corrected, not the code.

2Why and evidence

Review of 2026-10-07 by two independent reviewers (app; Bluetooth patches) plus a codec read; each finding below was re-read in the source before it was fixed. Host checks run-host-checks.sh pass; the old codec and the old alias policy fail the new assertions.

3Consequences

The changes ran on lynx image 2026100225; stallion gets them in the candidate of ADR-144. Patch 0013 is in the Bluetooth module of the lynx images; its Gradle unit test was not run (the host check passes). Findings left open are listed in status.md.

4Review when

Accepted when the candidate of ADR-144 ran on stallion with AIR-127 and AIR-190 re-run there.

Read from docs/governance/decision-log.md, entry ADR-143.